Skip to content

fix: limit commenting only to GitLab MRs

Tomas Vik requested to merge namespace-the-mr-commenting into main

When working with GitHub Pull Request extension, I've noticed that some of the GitLab Workflow UI elements are leaking into the GitHub comment UI. The reason for this was that we didn't limit where we show the GitLab buttons.

The proper way to do it is to give the CommentController a unique prefix and then only show the comment UI when the comment controller ID matches.

Commenting in GitHub Pull Request extension

before after
Extension_Development_Host_-_README_md__Pull_Request____github-test-repository Extension_Development_Host_-_README_md__Pull_Request____github-test-repository
Extension_Development_Host_-_README_md__Pull_Request____github-test-repository Extension_Development_Host_-_README_md__Pull_Request____github-test-repository
Edited by Tomas Vik

Merge request reports

Loading