Remove "ClientOnly" naming in Web IDE
MR: Pending
Description
Previously we had 2 versions of the Web IDE we would start: Remote Development and Client Only. We've removed the "Remote Development" type and now we can remove all references to "Client Only" naming since it's just confusing by itself.
Context
The following discussion from !353 (merged) should be addressed:
-
@pslaughter started a discussion: todo (non-blocking): We can remove all these references to "Client only" too now:
$ git grep -iE client.*only README.md: | Type | `Client only (Default)` | docs/dev/architecture_packages.md:- [Open Remote Development from the client only](https://youtu.be/blsVwJtpkOs) packages/example/src/components/ConfigForm.vue:import ConfigFormClientOnly from './ConfigFormClientOnly.vue'; packages/example/src/components/ConfigForm.vue: ConfigFormClientOnly, packages/example/src/components/ConfigForm.vue: <config-form-client-only v-bind="clientConfig" @update="onClientConfigUpdate" /> packages/example/src/components/WebIde.vue:const startClientOnly = async (el: Element, config: ClientConfig) => { packages/example/src/components/WebIde.vue: startClientOnly(container.value, { packages/vscode-bootstrap/src/main.ts:import { startClientOnly } from './start'; packages/vscode-bootstrap/src/main.ts: startClientOnly({ packages/vscode-bootstrap/src/start.test.ts:import { startClientOnly } from './start'; packages/vscode-bootstrap/src/start.test.ts: describe('startClientOnly', () => { packages/vscode-bootstrap/src/start.test.ts: const callStartClientOnly = async (partialConfig: Partial<ClientConfig> = {}) => { packages/vscode-bootstrap/src/start.test.ts: await startClientOnly({ packages/vscode-bootstrap/src/start.test.ts: await callStartClientOnly(); packages/vscode-bootstrap/src/start.test.ts: await startClientOnly({ packages/vscode-bootstrap/src/start.test.ts: await callStartClientOnly(); packages/vscode-bootstrap/src/start.test.ts: await callStartClientOnly({ featureFlags: { crossOriginExtensionHost: true } }); packages/vscode-bootstrap/src/start.test.ts: await callStartClientOnly({ extensionsGallerySettings: { enabled: false } }); packages/vscode-bootstrap/src/start.test.ts: await callStartClientOnly({ packages/vscode-bootstrap/src/start.ts:export const startClientOnly = (config: WebIdeExtensionConfig) => { packages/vscode-bootstrap/src/start.ts: amdModuleName('startClientOnly'), packages/web-ide/src/getIframeHtml.test.ts: ${'client only config'} | ${clientConfig} | ${{}}
I'll create a follow-up issue for this
😄
Acceptance Criteria
-
These references to "ClientOnly" naming have been renamed (for example, startClientOnly
becomesstart
)☝ -
We don't need a BaseConfig
andClientConfig
now. Let's have just 1Config
interface. https://gitlab.com/gitlab-org/gitlab-web-ide/-/blob/4fd2efd83953dd366c005b63ee6240d543c84ca1/packages/web-ide-types/src/config.ts#L120
Edited by Londyn Lane-Bellinger