Refactor feature specs around project services
The following discussion from !27778 (merged) should be addressed:
-
@jivanvl started a discussion: (+2 comments) Suggestion I'm not too sure about this one, perhaps @niskhakova might now better, but I don't think we shold be using these type of strings to visit links, we should try when possible to use the original service variable.
This applies for all rspec files in this MR
Context
In !28415 (merged), we introduced a shared context project service activation
in spec/support/shared_contexts/project_service_shared_context.rb
.
It was only applied in services that used a more standard flow so there are a few specs that are still not using this. Refactoring to use the shared context will make these tests much DRY-er and help with readability.
Some of these specs are:
spec/features/projects/services/user_activates_issue_tracker_spec.rb
spec/features/projects/services/user_activates_jira_spec.rb
spec/features/projects/services/user_activates_mattermost_slash_command_spec.rb
spec/features/projects/services/user_activates_slack_slash_command_spec.rb
spec/features/projects/services/user_activates_youtrack_spec.rb
- And possibly more.