Update Active checkbox component to use toggle
What does this MR do?
Issue #199882 (closed)
- Add a small Vue component to the Project Integrations form. Some attributes are passed from the HAML view with data attributes.
- Use GlToggle to replace the current checkbox.
- Update
app/assets/javascripts/integrations/integration_settings_form.js
to maintain the button change fromSave changes
toTest settings and save changes
. There is some duplication of the Vue state and a bit of a workaround to send events. In the longer term, we intend to move the whole form to view so this duplication and workaround is not needed. - Some feature specs have changed a bit due to switch from checkbox to clickable toggle.
Screenshots
Before | After |
---|---|
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖