Skip to content

Update Active checkbox component to use toggle

What does this MR do?

Issue #199882 (closed)

  • Add a small Vue component to the Project Integrations form. Some attributes are passed from the HAML view with data attributes.
  • Use GlToggle to replace the current checkbox.
  • Update app/assets/javascripts/integrations/integration_settings_form.js to maintain the button change from Save changes to Test settings and save changes. There is some duplication of the Vue state and a bit of a workaround to send events. In the longer term, we intend to move the whole form to view so this duplication and workaround is not needed.
  • Some feature specs have changed a bit due to switch from checkbox to clickable toggle.

Screenshots

Before After
Screen_Shot_2020-03-31_at_17.10.25 Screen_Shot_2020-03-31_at_17.12.54

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading