Skip to content

Revisit multi file snippet add button

Description

(Identified in !38855 (merged) as a follow-up)

  • How do we want to present to the user that they can only create 10 files?
  • When they've hit this limit, how should we communicate that?

Context

The following discussion from !38855 (merged) should be addressed:

  • @pslaughter started a discussion: (+4 comments)

    question (ux): @mnichols1 could you let me know what you think of this text for the "add button"?

    Enabled Disabled
    Screen_Shot_2020-08-13_at_2.21.59_AM Screen_Shot_2020-08-13_at_2.22.11_AM

    IMHO this is helpful at communicating:

    • When the user has less that 10 files, that they will only every be able to create 10 files (so that they don't start planning something elaborate that would take more files).
    • When the user hits their 10 file limit, it's obvious why this button is disabled.

Proposal

Display help text saying "Snippets are limited to 10 files" under "Add another file" button when user has reached the limit.

image

This should handle the scenario of when the user has less than 10 files that their max is 10 and when the button is disabled because 10 files have been created the text explains the reason.

From #235987 (comment 1424580000), the scenario in which a user has reached the 10 file limit is not something that is regularly encountered. Therefore we won't add this additional helper text as a something that is always visible on the page.

Original proposal of using a tooltip

If a user has reached the file limit, on hover display a tooltip explaining why the add file button is disabled.

Tooltip message

  • Snippets are limited to 10 files

image

Availability and Testing

Please run package-and-qa manual job before merging the MR to ensure existing tests still pass. Edge case scenarios might need to be tested manually during review.

Edited by Michael Le