[Feature flag] Remove combined_menu feature flag
What
Remove the :combined_menu
feature flag ...
Owners
- Team: Create - Editor
- Most appropriate slack channel to reach out to:
#g_create_editor
- Best individual to reach out to: Chad Woolley
Expectations
What are we expecting to happen?
The top navigation menu (Projects/Groups/More) will be combined into a single menu. See #301143 (closed) for more details.
What might happen if this goes wrong?
- Users may be unable to access items previously accessible via the old menus
- Users may be confused about where to find items in the new menu
What can we monitor to detect problems with this?
-
TODO: Determine what dashboards we need and add them. cc: @ericschurter @mle - do we have any plans for monitoring in the epic &5212 (closed)?
Beta groups/projects
If applicable, any groups/projects that are happy to have this feature turned on early. Some organizations may wish to test big changes they are interested in with a small subset of users ahead of time for example.
-
Individual members of Create - Editor group -
gitlab-org
/gitlab-com
groups - Others?
Roll Out Steps
-
Prepare to merge MR for necessary changes to make E2E tests pass with feature flag on (see !60335 (comment 568385682)) (TODO: determine exact timing this is needed). -
Enable on staging ( /chatops run feature set feature_name true --staging
) -
Test on staging -
Ensure that documentation has been updated -
Enable on GitLab.com for individual groups/projects listed above and verify behaviour ( /chatops run feature set --project=gitlab-org/gitlab feature_name true
) -
Coordinate a time to enable the flag with the SRE oncall and release managers - In
#production
mention@sre-oncall
and@release-managers
. Once an SRE on call and Release Manager on call confirm, you can proceed with the rollout
- In
-
Announce on the issue an estimated time this will be enabled on GitLab.com -
Enable on GitLab.com by running chatops command in #production
(/chatops run feature set feature_name true
) -
Cross post chatops Slack command to #support_gitlab-com
(more guidance when this is necessary in the dev docs) and in your team channel -
Announce on the issue that the flag has been enabled -
Remove feature flag and add changelog entry. Ensure that the feature flag definition YAML file has been removed in the same MR that is removing the feature flag from the code -
After the flag removal is deployed, clean up the feature flag by running chatops command in #production
channel
Rollback Steps
-
This feature can be disabled by running the following Chatops command:
/chatops run feature set --project=gitlab-org/gitlab feature_name false
Related issues and MRs
- related to #301143 (closed)
- related to #321904 (closed)
Availability & Testing
As the affected menu items are used in multiple tests across our E2E test suite, please give a heads-up to the Quality team before the feature flag is enabled on any environment. This will give us an opportunity to either exclude certain tests from running on that env (e.g. staging) or refactor the tests to pass with the ff on (once it is enabled globally), so we can avoid any blocked deployments down the track. It would also help if you could include a SET in any leading up MRs to do the necessary prep work (e.g. new selectors/methods).