Follow-up from "Allow Add Comment To Review"
The following discussion from !51718 (merged) should be addressed:
-
@pslaughter started a discussion: issue (non-blocking): There's a small issue where adding a draft comment to an image causes the comment to be visible in the Overview
The fix for this is small:
diff --git a/app/assets/javascripts/notes/stores/getters.js b/app/assets/javascripts/notes/stores/getters.js index 8d2d9d1d9f6..39f66063cfb 100644 --- a/app/assets/javascripts/notes/stores/getters.js +++ b/app/assets/javascripts/notes/stores/getters.js @@ -8,7 +8,7 @@ const getDraftComments = (state) => { } return state.batchComments.drafts - .filter((draft) => !draft.line_code && !draft.discussion_id) + .filter((draft) => !draft.file_path && !draft.discussion_id) .map((x) => ({ ...x, // Treat a top-level draft note as individual_note so it's not included in
I'll create a fast follow-up for this rather than blocking this merge. IMHO, this is an edge case with a not-so-bad effect. We're still at a net win
😄