Fix tabbing through disabled buttons on cluster_list
Context
The following discussion from !77407 (merged) should be addressed:
-
@pslaughter started a discussion: (+3 comments) I changed the tabindex for the tooltips to -1 instead, so that they are no longer focusable with tab, and that seems to make everything work correctly. Only 1 tab to move to the next element, and the button can still be activated with enter when tab-focused.
There's a downside to
tabindex="-1"
on the wrapping element when the underlying button is disabled. Withtabindex="0"
the disabled button will receive focus and the tooltip will show up. Withtabindex="-1"
and a disabled button, then the tab will skip over the disabled button.Screencast_2022-01-27_15_03_39
I think this is non-blocking because most users will be able to still hover over the disabled button to get the tooltip, but it would be great to create a small follow-up (maybe even with a ~"good for new contributors") for this
👍
Implementation guide
Here's the places we'll want to update.
See the bootstrap-vue docs and above discussion for possible fixes.
See the instructions in this MR for how to set up clusters in the local gdk.