Simplify Onboarding Progress Workers around one implementation
-
@dstull started a discussion: (+1 comment) note (non-blocking):
For follow-up.
There are a lot of workers in
app/workers/onboarding
that are action specific workers that I believe would be removed/replaced withOnboarding::ProgressWorker.perform_async
calls.- these include:
app/workers/onboarding/issue_created_worker.rb
app/workers/onboarding/pipeline_created_worker.rb
app/workers/onboarding/user_added_worker.rb
- these include:
Plan
-
Change the calls to the above workers as calls to app/workers/onboarding/progress_worker.rb
instead. Watch for unintended behavior changes.- See Move Onboarding Progress construct/updating to ... (#456534 - closed) and consider moving the invocations to
ee
at the same time as we'll need to do that eventually via that issue.
- See Move Onboarding Progress construct/updating to ... (#456534 - closed) and consider moving the invocations to
-
Create a follow-up to handle fully removing the unused workers using this guide
full follow up items that are solved by other issues
The following discussions from !149617 (merged) should be addressed:
-
@dstull started a discussion: (+2 comments) note (non-blocking):
We should likely follow-up here and think about what
code_added
means and how we might want to detect it. -
@dstull started a discussion: note (non-blocking):
Follow-up here to determine if we can remove this fully and migrate data if needed.
-
@dstull started a discussion: note (non-blocking):
The fact that we refer to
create a repository
asgit_write
is not great.We should, as a follow-up, discuss the idea of renaming this column in
onboarding_progresses
table torepository_created_at
or similar.- covered by #456533 (closed)
-
@acroitor started a discussion: (+1 comment) Is it possible to have a repository without a project ?
🤔