Skip to content

Resolve most RuboCop offenses for Cop/StaticTranslationDefinition

Baodong requested to merge gitlab-jh/jh-team/gitlab:refactor/cop-static-translation-definition into master

What does this MR do and why?

Resolve rubocop todo on Cop/StaticTranslationDefinition.

Resolved Cop/StaticTranslationDefinition cases, expect files under app/models/diff_viewer folder.

  • app/models/diff_viewer/image.rb
  • app/models/diff_viewer/rich.rb
  • app/models/diff_viewer/simple.rb

I didn't find a way to verify the effect of modifying them, so leave them as they are.

See #377947.

Other modifications are about message text, I refer to here comment for modification.

This MR modification refers to this document: https://docs.gitlab.com/ee/development/i18n/externalization.html#keep-translations-dynamic

Related MR: Catch more offenses in Cop/StaticTranslationDefinition

cc @splattael

Edited by Peter Leitzen

Merge request reports