Skip to content

Improve issuable confirm modal

Laurent Deketelaere requested to merge ali_o_kan/gitlab:7640-improve-issuable-delete-confirm-modal into master

What does this MR do and why?

As requested in #7640 (closed)

  • add title
  • update description
  • update primary button variant and text

And:

  • modify confirmViaGlModal to support title definition and html in description
  • split confirmViaGlModal and confirmAction to simplify testing with jest.mock
  • Add confirmViaGlModal tests

Screenshots or screen recordings

Before

image

After

image

How to set up and validate locally

To delete a merge request:

  • Go to the merge request you want to delete, and select Edit.
  • Scroll to the bottom of the page, and click on Delete button

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #7640 (closed)

Edited by Laurent Deketelaere

Merge request reports