Improves modal copy when deleting page assets leads to package deletion
requested to merge 368908-improve-modal-copy-when-deleting-either-the-last-or-package-files into master
What does this MR do and why?
When the user deletes all or last of the package assets from a package, it may not be obvious to the user that delete would be deleted.
This MR updates the copy to be more specific in such cases.
Screenshots or screen recordings
| header | header |
|---|---|
| all files (before) |  |
| all files |  |
| last file (before) |  |
| last file |  |
Since the screenshot was taken before #349515 (closed) got merged, the button text still says Permanently delete package. Instead the modal should now say Permanently delete instead as mentioned
How to set up and validate locally
- Follow instructions here to publish a new package
- Publish couple of packages. One with only 1 file and another with multiple files
- Visit package details page
- Attempting to delete last package file should show appropriate message as above
- Attempting to delete all package files should show appropriate message as above
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Closes #368908 (closed)
Edited by Rahul Chanila