Skip to content

Add compound assertion when delete_refs uses an invalid ref format

John Cai requested to merge jc-expect-invalid-ref-format-error into master

What does this MR do and why?

Add compound assertion when delete_refs uses an invalid ref format

In gitaly!4921 (merged), Gitaly will learn to validate ref formats with a backslash \ in it. Currently, this case falls through to the git update-ref prepare stage, which gets sent back as a GitError.

This is not ideal however, since it's an error we should catch when validating refs.

Once the Gitaly MR is merged, it will start sending a structured error, which will get prased in ref_service.rb. Until then, we need the spec to expect both kinds of errors. Once the Gitaly MR is merged, we can remove the assertion expecting Gitlab::Git::Repository::GitError.

follow up issue: #377440

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by John Cai

Merge request reports