Skip to content

Remove and add ci_job_variables.raw

Furkan Ayhan requested to merge 374616-fa-redo-re-adding-ci_job_variables-raw-column into master

What does this MR do and why?

In previous work (!98527 (merged)), we added a migration that re-adding the ci_job_variables.raw column to make all the raw columns as FALSE because we do not set TRUE anywhere.

During this migration, we missed a place where multi-version deployments can cause wrong data.

So in this new migration, we will fix the old data by re-adding the column. Also, we prevent future wrong data by adding "raw: true" to the missed place.

Explanation of the wrong data: !98527 (comment 1126894456)

Step MR
1. Remove and add the raw attribute again !98527 (merged)
2. Fix ci_job_variables.raw (!98527 (comment 1126894456)) <-- HERE
3. (Optional) Change the logic of to_runner_variable to support raw. !100020 (merged)

Related to #374616 (closed)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #374616 (closed)

Merge request reports