Dequarantine and Fix Empty State Test in spec/features/dashboard/projects_spec
What does this MR do and why?
This test was experiencing flakiness when asserting on the starred empty image due to the way the image is lazy loaded, since it would sometimes come across the placeholder_image
instead (see app/helpers/lazy_image_tag_helper.rb
).
As a best practice, we should avoid writing assertions on images that are lazy loaded.
Since the test is already finding the .empty-state
class and checking for the copy text, this should be sufficient and also aligns with how other specs currently test empty states.
Related issue: #222357 (closed)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.