Skip to content

Hide Reviewers Edit Button when no permissions

Niklas van Schrick requested to merge taucher2003-group/gitlab:fix-reviewers-edit into master

What does this MR do and why?

The Edit Button for Merge Request Reviewers was visible to MR authors, even if they don't have the permission to edit the reviewers.
The action got silently ignored when executed.

This MR hides the button again, and only shows it when you actually have the permission to set reviewers.

Screenshots or screen recordings

image

How to set up and validate locally

  1. Log in as non-admin (or impersonate someone)
  2. Fork a repository
  3. make some changes and create a MR to the upstream project
  4. Observe that the Edit Button for the Reviewers is no longer visible
  5. Exit impersonation (or log in as admin/repo owner)
  6. See that the Edit Button is still available in the MR

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports