Skip to content

Make Gitlab/Json cop stricter

Robert May requested to merge stricter-json-cop into master

What does this MR do and why?

Describe in detail what your merge request does and why.

We need to "encourage" engineers to use the Gitlab::Json class for converting objects to JSON due to the notable performance improvements we have in that class. This addition to the cop ensures that to_json calls on objects are detected as failures as well as direct calls to the JSON class.

Related #217633 (closed)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Robert May

Merge request reports