Skip to content

Allow group users to bulk delete group runners

Miguel Rincon requested to merge 361721-enable-bulk-delete-groups into master

What does this MR do and why?

Allow group users to bulk delete group runners

This change is not widely available, it is gated behind the feature flag runners_group_bulk_delete.

MR
Add feature spec to test bulk delete (!100941 - merged) done!
Refactor bulk delete frontend components (!101036 - merged) done!
Allow group users to bulk delete group runners (!101209 - merged) ☝ You are here!

Screenshots or screen recordings

image

How to set up and validate locally

  1. Enable the group runners bulk delete 
    Feature.enable(:runners_group_bulk_delete)
  2. Visit any group with one or more runners e.g. http://gdk.test:3000/groups/flightjs/-/runners
  3. Select one or more runners with the checkbox.
  4. Confirm to delete them.

Note: If you sign in as a group owner, under certain conditions you may not delete certain runners, such as when listing shared runners. In this case:

  1. Enable the group runners bulk delete 
    Feature.enable(:runners_group_bulk_delete)
  2. Given you have some shared runners
  3. Log in a group owner (or impersonate one)
  4. Visit any group with one or more runners e.g. http://gdk.test:3000/groups/flightjs/-/runners
  5. Disable "Show only inherited"
  6. Verify shared runners cannot be deleted: Don't have a checkbox.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #361721 (closed)

Edited by Miguel Rincon

Merge request reports