Skip to content

Admin Jobs: table, cache and query

Andreas Deicha requested to merge siemens/gitlab:feature/add-job-status-counts-graphql into master

What does this MR do and why?

This merge request is a step towards refactoring the admin jobs page from Haml to Vue and is related to the feature flag admin_jobs_vue. The ultimate goal is to refactor the page and add a filter to it. The relevant issues are: #22626 (closed), #329224, and #262679 (closed). This merge request, is a complete test implementation of the entire feature.

The changes made in this merge request include:

  • Adding a new GraphQL query called get_all_jobs.query.graphql
  • Adding a new cache
  • Extending the new Vue component that contains the page, called admin_jobs_table_app.vue
  • Moving the components folder one level up in the folder structure for consistency, from /pages/admin/jobs/index/components/ to /pages/admin/jobs/components/
  • Adding tests

Please note that the changes may seem significant, but the folder move is merely a reorganization and does not affect the functionality of the code.

Screenshots or screen recordings

New jobs page if FF is enabled image

How to set up and validate locally

  1. rails c in console
  2. Feature.enable(:admins_jobs_page)
  3. Go to Admin > CI/CD > Jobs

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Andreas Deicha

Merge request reports