Skip to content

Rename PipelinePresenter#name to PipelinePresenter#event_type_name

Reuben Pereira requested to merge rp/rename-pipeline-entity-name into master

What does this MR do and why?

Describe in detail what your merge request does and why.

Users can now set names for pipelines (!97502 (merged)). The name is currently stored in PipelineMetadata#name. And there is a Pipeline#name method, which is delegated to PipelineMetadata.

PipelinePresenter#name overrides Pipeline#name. Additionally, we will want to expose Pipeline#name in the internal pipelines API, which could cause confusion with the existing name attribute. The public pipelines API does not return a name attribute.

  1. This MR renames PipelinePresenter#name to PipelinePresenter#event_type_name.
  2. This MR also adds an event_type_name attribute in the internal API response, but doesn't remove the name attribute. We will keep both attributes for one milestone, and will remove the name attribute in 15.7. This is done for multi-version compatibility (https://docs.gitlab.com/ee/development/multi_version_compatibility.html).

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Reuben Pereira

Merge request reports