Remove canRenew condition from billing page
What does this MR do and why?
Let the GraphQL call handle the Renew
button visibility, we already account for subscription end date and trials on backend side when computing the inRenewalPeriod
value on the API side.
The changes are targeting EDU/OSS subscriptions as they have a longer period for renewal (3 months vs 15 days in all the other cases)
Related to #363439 (closed) && #378283 (closed)
Screenshots or screen recordings
Before | After |
---|---|
How to set up and validate locally
Prerequisites: GitLab and CustomersDot connected, Zuora account
- (Zuora) Create an EDU/OSS SaaS subscription in Zuora with the term date in 2 months
- (CustomersDot) Assign this subscription to a group
- (GitLab) Navigate to that group billing page (http://localhost:3000/groups/test-group/-/billings)
- (GitLab) Check if the visibility of the buttons set correctly
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Diana Zubova