Skip to content

Resolve "Add VueRouter to pipeline tabs"

Frédéric Caplette requested to merge 378196-add-vuerouter-to-pipeline-tabs into master

What does this MR do and why?

In the context of a big pipeline tabs migration (pipelines/:id) we had previously removed the routes for each tab. However, it was pointed out that this removed some convenient functionalities like link sharing. This MR introduce VueRouter to the new pipeline tabs so that we can navigate using routes instead of query params. This has the big advantage of being able to share links easier or reload the page while on the right route, which will keep you on the right tab.

Notes: Yes the MR is big, but not that big and it covers the bare minimum we need for the VueRouter setup to work and have a green pipeline. Let me know if you have questions.

Link to the pipeline tabs issue for context: #230749 (closed)

Screenshots or screen recordings

No visual changes

How to set up and validate locally

  1. Have a defined CI/CD configuration. You can use a very basic configuration defined in CI/CD => Editor 
   job1:
     script: echo hello
  1. Set up a runner (see https://docs.gitlab.com/runner/configuration/macos_setup.html#set-up-macos-runners)
  2. Run a pipeline
  3. Go to CI/CD => Pipelines => Pipeline ID
  4. Navigate between the tabs
  5. notice the URL changes and you can navigate between the tabs

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #378196 (closed)

Edited by Frédéric Caplette

Merge request reports