Skip to content

Fix design management styling in MR diff

Coung Ngo requested to merge 378463-fix-merge-request-design-management into master

What does this MR do and why?

This fixes the design management button styling in MR diffs. The design management css was extracted to page-specific bundles in !100283 (diffs) but failed to add it to the MR show page as well. This MR extracts the design management css to its own scss file and adds it to the MR show page to fix the UI issue.

Related css epic: &3694

Screenshots or screen recordings

before after
Screenshot_2022-10-20_at_18-13-37_Repellat_qui_dolore_quisquam_cum_harum_id_ducimus_eligendi.___7____Merge_requests___Gitlab_Org___Gitlab_Test___GitLab Screenshot_2022-10-20_at_18-20-37_Repellat_qui_dolore_quisquam_cum_harum_id_ducimus_eligendi.___7____Merge_requests___Gitlab_Org___Gitlab_Test___GitLab

How to set up and validate locally

  1. Go to an MR diff with an image, e.g. http://127.0.0.1:3000/gitlab-org/gitlab-test/-/merge_requests/7/diffs
  2. Click on the diff image and create a comment
  3. Confirm the fix works

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #378463 (closed)

Edited by Coung Ngo

Merge request reports