Skip to content

Fix Ci::RegisterJobService return value

Pedro Pombeiro requested to merge pedropombeiro/fix-register_job_service-return-value into master

What does this MR do and why?

Describe in detail what your merge request does and why.

Two years ago the ::Ci::RegisterJobService::Result type was changed, but the line changed in this MR wasn't adapted. Fortunately this didn't impact the functionality since valid? will default to a falsey value anyway.

This MR fixes the return value. We can see in the original definition that build_json didn't exist and therefore the false argument was meant for valid?.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Pedro Pombeiro

Merge request reports