Skip to content

Add confirmation modal for deleting an artifact

What does this MR do and why?

This MR adds a step to the process of deleting an artifact in the artifacts view: clicking the delete button next to an artifact should open a modal, then clicking the delete button in the modal should delete the artifact.

Screenshots or screen recordings

before after
Screen_Recording_2022-10-24_at_13.45.31 Screen_Recording_2022-10-24_at_13.43.47

How to set up and validate locally

  1. git checkout 370150-add-artifact-delete-confirmation-modal
  2. echo "Feature.enable(:artifacts_management_page)" | bundle exec rails console
  3. run a pipeline that generates artifacts - for this you'll need to set up a local runner for GDK or enable runners in gitpod
you can use this CI yaml to generate some sample artifacts:
# .gitlab-ci.yml

potato:
  stage: build
  script:
    - echo 'potato' >> potato.txt
  artifacts:
    expose_as: 'potato'
    paths: ['potato.txt']

tomato:
  stage: build
  script:
    - echo 'tomato' >> tomato.txt
  artifacts:
    expose_as: 'tomato'
    paths: ['tomato.txt']

pineapple:
  stage: build
  script:
    - echo 'pineapple' >> pineapple.txt
  artifacts:
    expose_as: 'pineapple'
    paths: ['pineapple.txt']

apple:
  stage: build
  script:
    - echo 'apple' >> apple.txt
  artifacts:
    expose_as: 'apple'
    paths: ['apple.txt']

toblerone:
  stage: build
  script:
    - echo 'toblerone' >> toblerone.txt
  artifacts:
    expose_as: 'toblerone'
    paths: ['toblerone.txt']
  1. navigate to the project, and in the sidebar choose CI/CD => Artifacts
  2. expand a job and click the delete button next to a single artifact (deleting all artifacts for a job is coming soon)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #370150 (closed)

Edited by Miranda Fluharty

Merge request reports

Loading