Skip to content

Fix sidekiq-cron poll interval to scale with number of process

Alejandro Rodríguez requested to merge fix-sidekiq-cron-poll-interval into master

What does this MR do and why?

Describe in detail what your merge request does and why.

On !99030 (merged) we purported to allow sidekiq-cron to base its polling interval on scaled_poll_interval. In that MR we gave precedence to Sidekiq.options[:cron_poll_interval] but we neglected to note that it is always set to a default (30s), which meant scaled_poll_interval was never used.

Here we switch to instead check for Gitlab.config.cron_jobs.poll_interval, which we know stays nil unless overwritten by the user.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports