Skip to content

Clarify duplicate package handling

Duncan requested to merge tf-dupe-module into master

What does this MR do and why?

Docs for the registry do not note that conflicts can happen due to the same package existing OR a same package / same version conflict.

Screenshots or screen recordings

N/A

How to set up and validate locally

  1. Create project that performs a Terraform Module Upload (https://gitlab.com/gitlab-gold/duncan/tf-upload)
  2. Upload a module with that project
  3. Create a project that will try to upload a new version of the same module (https://gitlab.com/gitlab-gold/duncan/tf-noupload)
  4. 403: https://gitlab.com/gitlab-gold/duncan/tf-noupload/-/jobs/3225936591#L39

Validate against the source: https://gitlab.com/gitlab-org/gitlab/-/blob/6083b2e6b9411ae990b8db95155176ee664d0b1c/app/services/packages/terraform_module/create_package_service.rb#L10-11

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports