Convert the broadcast messages form to Vue
What does this MR do and why?
Related issue: #368847 (closed)
Continues converting the broadcast messages page to a Vue app. All UI changes are hidden behind the vue_broadcast_messages
feature flag.
Change summary:
- Render the form component on the edit page when the feature is enabled
- Move
index.js
->index/index.js
so it's not bundled with the edit page - Adds the form to the index page
- Converts the start/end times in the table to the user's local timezone, to match the new form
Known issues:
GlBroadcastMessage
doesn't have an option for Notification type broadcast messages ordismissible
(MR)-
GlDatepicker
doesn't have a time picker option, so I'm relying on<gl-form-input type="time" />
. This is currently styled by the browser, and doesn't match the height of other inputs
Screenshots or screen recordings
Without feature | With feature | |
---|---|---|
Banner (Index) | ||
Notification (Index) | ||
Banner (Edit) | ||
Notification (Edit) |
How to set up and validate locally
- Enable the Vue app
Feature.enable(:vue_broadcast_messages)
- Navigate to the broadcast messages view: http://gdk.test:3000/admin/broadcast_messages
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Alex Pennells