Skip to content

Run compile-storybook as-if-foss for storybook config changes

Nao Hashizume requested to merge 379251-run-compile-story-book-as-if-foss into master

What does this MR do and why?

This MR runs compile-storybook as-if-foss job when storybook config file change is introduced in merge requests in gitlab project.

This will catch any potential master:foss-broken issue such as #379242 (closed) before gitlab-foss project runs compile-storybook job in the pipeline.

Closes #379251 (closed)

Testing

Tested changes on !102453 (closed).

File Change Result
when storybook/config/preview.js changes (e273fab1) compile-storybook as-if-foss is created
https://gitlab.com/gitlab-org/gitlab/-/pipelines/680266423#/
Regression:
when app/assets/javascripts/pipelines.js changes (24c92582)
compile-storybook as-if-foss job is created
NO yaml invalid error is found
https://gitlab.com/gitlab-org/gitlab/-/pipelines/680262206#/

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Nao Hashizume

Merge request reports

Loading