Skip to content

Avoid streaming audit events when there is no change

Harsimar Sandhu requested to merge 370317-dont-create-group-link-audit-event-for-same-change into master

What does this MR do and why?

This MR stops streaming of group link audit events when there is no update to auditing columns. This was only happening if a user abuses the system and instead of using UI to change group link attributes uses api to change values.

How to set up and validate locally

  1. Setup audit event streaming on group https://docs.gitlab.com/ee/administration/audit_event_streaming.html
  2. Go to a project and open members from sidebar
  3. Click on Invite a group, fill the form and submit.
  4. Now update the group link using using api. you can obtain the curl by inspecting network call when we update via UI
  5. On master branch you will be able to stream audit events even when you update the same value twice
  6. On this branch only first update event will be streamed, for same value updates audit event will not stream any event.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #370317 (closed)

Edited by Harsimar Sandhu

Merge request reports