Skip to content

Improve test coverage for Banzai::ReferenceParsers

Jessie Young requested to merge jy-banzai-test-coverage into master

What does this MR do and why?

  • I made some updates to these parsers in a separate MR and had an rspec undercoverage pipeline fail: https://gitlab.com/gitlab-org/gitlab/-/jobs/3254954935
  • The coverage issue is specifically for the ELSE case for "node.has_attribute?(project_attr)"
  • I also noticed that there was no N+1 spec for CommitRangeParser
  • MR where this issue came up: !98694 (merged)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jessie Young

Merge request reports