Skip to content

Don't run jest as-if-foss when run-all-jest

Thong Kuah requested to merge fix-invalid-yaml-frontend into master

What does this MR do and why?

Fix yaml invalid MRs that has pipeline:run-all-jest labels:


Found errors in your .gitlab-ci.yml:

    'jest as-if-foss 1/2' job needs 'rspec-all frontend_fixture as-if-foss' job, but 'rspec-all frontend_fixture as-if-foss' is not in any previous stage
    'jest as-if-foss 2/2' job needs 'rspec-all frontend_fixture as-if-foss' job, but 'rspec-all frontend_fixture as-if-foss' is not in any previous stage

You can also test your .gitlab-ci.yml in CI Lint 

I think jest as-if-foss shouldn't run when pipeline:run-all-jest label is added, much like rspec as-if-foss doesn't run when pipeline:run-all-rspec label is added.

Example broken MR: https://gitlab.com/gitlab-org/gitlab/-/pipelines/682958807#

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

  1. Create an MR that only has backend changes
  2. Add pipeline:run-all-jest label
  3. Approve the MR
  4. The create pipeline will fail, like in https://gitlab.com/gitlab-org/gitlab/-/pipelines/682958807

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Thong Kuah

Merge request reports

Loading