Skip to content

Shutoff spellcheck on CI variables

Seth Berger requested to merge sethgitlab-master-patch-90736 into master

What does this MR do and why?

spellcheck=false directs browsers not to spell check fields. All sensitive fields should have spellcheck=false since browsers like Chrome and Edge may send data in those fields to the cloud for spell check unless it is explicitly turned off.

Addresses: https://gitlab.com/gitlab-org/gitlab/-/issues/375380

Screenshots or screen recordings

Before: image

After: image

How to set up and validate locally

Go to a project, Settings > CI/CD > Variables Click "Add Variable" Type in a misspelled word in the value field. You should not see red underscores.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Seth Berger

Merge request reports

Loading