Skip to content

Convert specs for search nav change to vertical & Vue (3)

Terri Chu requested to merge 377899-convert-specs-3 into master

What does this MR do and why?

Related to #377899 (closed)

After converting scope navigation from horizontal/HAML to vertical/Vue, we need to convert all specs for the Search Page.

There is a large MR with all changes in it, but that MR got too big so it's been broken down into smaller pieces:

  1. Convert specs for search nav change to vertical & Vue 1/3 (merged)
  2. Convert specs for search nav change to vertical & Vue 2/3 (merged)
  3. Convert specs for search nav change to vertical & Vue 3/3 👈 this MR

This MR can be merged once !103409 (merged) has been merged and contains the following changes:

  • move n+1 query checks from features spec into requests spec
  • fixes for global search redactions specs
  • some minor cosmetic changes to specs

Screenshots or screen recordings

N/A

How to set up and validate locally

While the changes in this MR are specs only changes, the UI changes are behind a feature flag

  1. checkout this branch

  2. In rails console enable the feature flag

    Feature.enable(:search_page_vertical_nav)

  3. Visit search page http://your-gdk.url/search

  4. Admire vertical navigation

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Terri Chu

Merge request reports