Skip to content

Add runner tags selection for on-demand scans form

Artur Fedorov requested to merge 345430-runner-tags-section into master

What does this MR do and why?

Describe in detail what your merge request does and why.

This MR resolves frontend part of #345430 (closed)

During the setup of On Demand DAST, users could specify a Runner Tag to be referenced so that DAST scans use specific runners rather than generic runners (including the GitLab Runner Cloud on SaaS) while also allowing the project to still use generic runners for all other jobs on the given project.

Note:

Content of tags dropdown is aligned in center. It will be fixed with new gitlab-ui release. MR is already merged

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

before
Screenshot_2022-11-14_at_17.31.50
after
select

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Enable flag by enabling rails console in terminal
   Feature.enable(:on_demand_scans_runner_tags)
  1. If you don't have tags you can configure tags on admin runners here /admin/runners or on group runner here /groups/GROUP_NAME/-/runners/
  2. Then go to /on_demand_scans create new scan or edit exiting
  3. You should see dropdown with tags

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #345430 (closed)

Edited by Artur Fedorov

Merge request reports