Improve project merge request settings
What does this MR do?
CE port: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/26495
Part of larger MR https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10318
This is just the changes for the 2 MR settings panels.
-
Merge request section
-
-
labels in ‘Merge request’ radio selection should be regular font weight. Explanations below the labels should be styled as ‘secondary’ text
-
-
-
‘Description parsed with GitLab Flavored Markdown.’ should be regular, not italic and styled as ‘secondary’ text
-
-
-
labels in ‘Merge request’ checkboxes should be regular font weight. Explanations below the labels should be styled as ‘secondary’ text
-
-
-
‘Save changes’ buttons should be disabled until there’s a change to save
-
-
Merge request approvals section
-
-
change the ‘Approvers’ label to ‘Add approvers’
-
-
-
limit the width of the ‘Approvers’ input field to input-lg (320px)
-
-
-
‘Add’ button should be the default (white) style) and disabled until there’s something to add
-
-
-
‘Approval required’ input field should be limited to input-xs (80px)
-
-
-
checkbox labels should be regular font weight
-
What are the relevant issue numbers?
Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/49738
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated via this MR -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Tested in all supported browsers -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides -
Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process. -
EE specific content should be in the top level /ee
folder -
For a paid feature, have we considered GitLab.com plans, how it works for groups, and is there a design for promoting it to users who aren't on the correct plan? -
Security reports checked/validated by reviewer
Edited by Luke Bennett