Skip to content

Improve project merge request settings

Luke Bennett requested to merge proj-settings-ok-mr-settings-only into master

What does this MR do?

CE port: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/26495

Part of larger MR https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10318

This is just the changes for the 2 MR settings panels.

  • Merge request section
    • labels in ‘Merge request’ radio selection should be regular font weight. Explanations below the labels should be styled as ‘secondary’ text
    • ‘Description parsed with GitLab Flavored Markdown.’ should be regular, not italic and styled as ‘secondary’ text
    • labels in ‘Merge request’ checkboxes should be regular font weight. Explanations below the labels should be styled as ‘secondary’ text
    • ‘Save changes’ buttons should be disabled until there’s a change to save
  • Merge request approvals section
    • change the ‘Approvers’ label to ‘Add approvers’
    • limit the width of the ‘Approvers’ input field to input-lg (320px)
    • ‘Add’ button should be the default (white) style) and disabled until there’s something to add
    • ‘Approval required’ input field should be limited to input-xs (80px)
    • checkbox labels should be regular font weight

Screenshot_2019-03-20_at_12.14.02

Screenshot_2019-03-20_at_12.15.04

What are the relevant issue numbers?

Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/49738

Does this MR meet the acceptance criteria?

Edited by Luke Bennett

Merge request reports

Loading