Skip to content

Enforces HTTP/HTTPS schemes in Kube Client

Rodrigo Tomonari requested to merge rodrigo/enforce-schemes-in-kube-client into master

What does this MR do and why?

Validates the api_prefix URL schemes before making any request in KubeClient. The schemes are being added because the schemes keyword in the Gitlab::UrlBlocker will be modified to be mandatory later.

I am using the schemes http https as they are the same ones used in the model Clusters::Platforms::Kubernetes validation.

Related to: #372317 (closed)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Rodrigo Tomonari

Merge request reports

Loading