Skip to content

Validate sub entires of each CI schema yaml entry

Frédéric Caplette requested to merge 381535-improve-negative-tests-for-json-schema into master

What does this MR do and why?

We currently have the unfortunate when testing the Ci schema that each "Negative test"( which means a test that assert that the schema throws an error properly when it is invalid) needs its own file. Ideally, you would write all of the test for a single keyword inside one file.

To address this, we use another loop on Object.keys for each individual test file, which effectively mean that we are now testing each blob on its own! 🎉

In this MR I migrated a series of file into one as an example, but I believe having only one here is good enough as an example, and then we could have either one big migration MR for all duplicated files or do several small ones for each of the file.

Note: We also now do the same for positive tests. Why? Because if the logic to make new "sub JSON files" was broken, all of the negative tests would pass so calling the exact same method for both ensure that the method itself is not broken.

Screenshots or screen recordings

No changes

How to set up and validate locally

  • Check the pipeline is green
  • PROFIT

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #381535 (closed)

Edited by Frédéric Caplette

Merge request reports