Skip to content

Update gitlab pages spec filter and template

Jason Zhang requested to merge jz-static-pages-spec-filter-update into master

What does this MR do and why?

Previously we had 'except subdomain production' which doesn't actually do anything. According to gitlab-org/quality/pipeline-common!244 (comment 1164879999) - "that restricting subdomain only works when the value is a subdomain. So that example would have worked if the URL was production.gitlab.com "

Also from that MR, we learned that this spec actually does run fine on production: https://ops.gitlab.net/gitlab-org/quality/production/-/jobs/8439650 Update the filter to remove that entirely just for explicitness.

The second update: Change from :jekyll to :plainhtml - as I've been suggested by @kassio it increases test setup time.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports