Skip to content

Add some debugging data to the verify_deploy function

David Dieulivol requested to merge 382234-more_health_checks_for_review_apps into master

What does this MR do and why?

Adds some more debugging info for when a verify_deploy fails.

Note: The steps present in gitlab-org/quality/engineering-productivity/team!36 (merged) haven't been added yet. I would like to wait for #382134 (comment 1169011207) to be resolved for us to know what we really need to properly debug an incident like this one.

See an example here: https://gitlab.com/gitlab-org/gitlab/-/jobs/3310730863

How to set up and validate locally

{
  export CI_ENVIRONMENT_SLUG=review-schin1-val-ez6edm # Change this
  export CI_ENVIRONMENT_URL="https://gitlab-${CI_ENVIRONMENT_SLUG}.gitlab-review.app"
  source scripts/utils.sh
  source scripts/review_apps/review-apps.sh && run_timed_command "verify_deploy"|| (display_deployment_debug && exit 1)
}

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #382234 (closed)

Edited by David Dieulivol

Merge request reports