Skip to content

Clean up ci_variable_settings_graphql ff

Frédéric Caplette requested to merge fc-remove-variable-settings-ff into master

What does this MR do and why?

Clean up ci_variable_settings_graphql FF by removing it's definition and all legacy files. Note that this FF was covering up a big refactor and not a different behaviour. The feature specs have also been updated.

Important note to reviewers: the code is ready, but I am waiting after the latest refactor to hit production before merging this which is why this is in draft. Depending on how quick the reviews are, we might wait a bit after all approvals are given (like a day) or the draft status will have been removed. If this MR is no longer in draft, then it would mean it's ready to merge 👍🏻

Screenshots or screen recordings

No changes

How to set up and validate locally

  1. go to Project => Settings => CI/CD => variables
  2. Open the network tab
  3. Makes sure the variables are fetched via graphql
  4. Add, update and delete variables
  5. Notice that it still works
  6. Make sure that each CRUD action is done through graphql
  7. go to Group => Settings => CI/CD => variables
  8. Repeat step 2 to 6
  9. go to Admin => Settings => CI/CD => variables
    1. Repeat step 2 to 6

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Frédéric Caplette

Merge request reports