Update Global Search vertical navigation wiki scope condition
What does this MR do and why?
When testing in staging env I found a missing check for the WIKI menu item. Under some conditions (no Project selected for example) the vertical menu shows the WIKI item when it should not.
Screenshots or screen recordings
no FF | with FF |
---|---|
How to set up and validate locally
- Checkout this branch
- Enable the search_page_vertical_nav
Feature.enable(:search_page_vertical_nav)
- To enable Advancer Search navigate to
http://127.0.0.1:3000/admin/application_settings/advanced_search
- Enable
Search with Elasticsearch enabled
- Navigate to the search page
http://127.0.0.1:3000/search?search=test
or any other search term - Wiki is showing up is contingent on Project/Group (some groups and projects have it and some don't) as well as whether the advanced search is enabled.
advanced search disabled -> | enable -> | advanced search enabled |
---|---|---|
If the above steps to enable elasticsearch don't work please refer to this document https://gitlab.com/gitlab-org/gitlab-development-kit/-/blob/main/doc/howto/elasticsearch.md
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #293740 (closed)
Edited by Tomas Bulva