Skip to content

Create groups selector

Alexander Turinske requested to merge 382149-group-dropdown into master

What does this MR do and why?

Describe in detail what your merge request does and why.

Create groups selector and allow for multiple actions

  • create user groups query
  • create groups selector
  • selects group type for existing policies with groups already selected
  • allows for both user and group selection
  • adds tests

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

NOTE: There are some UX issues with the GlListbox being used; they will be fixed in FE: Fix search-box-by-type input box in Gl-Form (#381649 - closed) and FE: Display selected users/groups (#382148 - closed)

Scenario Screenshot
Add group add group dropdown

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Upload a GitLab Ultimate license
  2. Enable the scan_result_role_action feature flag: echo "Feature.enable(:scan_result_role_action)" | rails c
  3. Navigate to http://gdk.test:3443/flightjs/Flight/-/security/policies/new?type=scan_result_policy
  4. Verify users can add groups

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #382149 (closed)

Edited by Alexander Turinske

Merge request reports

Loading