Skip to content

Adds ci_stage to GenericCommitStatus creation

Laura Montemayor requested to merge update-ci-stage-for-generic-commit-statuses-1 into master

What does this MR do and why?

This MR is 1/3 for removing stage from GenericCommitStatus. In this MR, we add a ci_stage to the following places where a GenericCommitStatus is created, along with stage_idx:

  • UpdatePagesService
  • lib/api/commit_statuses.rb
  • db/fixtures/development/14_pipelines.rb

We add Ci::Stage creation and other missing stuff like context stage stage_idx into those 3 places MR 2: Remove before_validation :set_default_values from the GenericCommitStatus model MR 3: Remove stage from the service, the API, and the seed

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Laura Montemayor

Merge request reports