Skip to content

Fixing some of our color variables to utilize the updated gray variable palette

Nick Brandt requested to merge fix-darkmode-gray-variables into master

What does this MR do and why?

In !103662 (merged) we updated our gray variables in the GitLab project based on the changes in gitlab-ui (gitlab-ui!3125 (merged)). There are currently some other color variables being utilized in the product that were custom defined (not based on the gray palette). This MR updates those variables to be based on our new gray palette.

Additionally, this fixes an issue where the notes items border and lines were the same as the background on dark mode (and very light on light themes).

Screenshots or screen recordings

Light Themes

Location Before After
Project light-project light-project
Issue light-issue light-issue
Boards light-boards light-boards
Main Menu light-main-menu light-main-menu

Dark Mode

Page Before After
Project dark-project dark-project
Issue dark-issue dark-issue
Boards dark-boards dark-boards
Main Menu dark-main-menu dark-main-menu

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Nick Brandt

Merge request reports