Skip to content

Fix hardcoded url in about dropdown

Kun Qian requested to merge gitlab-jh/jh-team/gitlab:fix-hard-coded-url-in-about-dropdown into master

What does this MR do and why?

Replace the hardcoded url in About Gitlab dropdown with property defined in rails so that GitLab JH could override them, while the urls will stay unchanged in upstream.

Screenshots or screen recordings

Changes in GitLab JH

before after
image image

How to set up and validate locally

  1. Run GDK with GitLab JH
  2. Visit any page with a unsigned in guest role
  3. Click About GitLab on left top
  4. Check the links in the dropdown

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

/cc @daveliu @JeremyWuuuuu @orozot

Merge request reports