Replace and ignore send_user_confirmation_email
What does this MR do and why?
This MR replaces the pre-existing send_user_confirmation_email
application setting with the new email_confirmation_setting
enum and ignores the old column.
This is done as a pre-requisite to remove the send_user_confirmation_email
in milestone 15.8 and to remove soft_email_confirmation
feature flag.
How to set up and validate locally
- No references to
send_user_confirmation_email
other than the migrations from !102697 (merged) andignore_column
in ApplicationSetting model - If
send_user_confirmation_email
is set to true beforedb:migrate
is run, then the newemail_confirmation_setting
should returnhard
- This can be confirmed by opening the rails console (
gdk rails c
) and verifying viaGitlab::CurrentSettings.email_confirmation_setting
returninghard
orGitlab::CurrentSettings.email_confirmation_setting_hard?
returningtrue
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #371638 (closed)
Edited by Jay Montal