Skip to content

Cleanup praefect_manager test class

John McDonnell requested to merge jmd-cleanup-praefect-manager-class into master

What does this MR do and why?

The praefect_manager class is quite large and has a lot of very specific methods that could be refined to be a bit more generic, so this is a first pass at cleaning it up to make it a bit more manageable.

  • Removing redundant test code
  • Simplifying class methods to minimise size of class

How to set up and validate locally

  • CI/CD on GitalyCluster tests should continue to all pass

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by John McDonnell

Merge request reports