Limit group activity metrics value to 999
What does this MR do and why?
Limits the value displayed in group activity metrics
- With the limit at 999, when we have 1000 display
999+
- Add a tooltip which says "Results limit reached"
Screenshots or screen recordings
Screen_Recording_2022-11-23_at_11.23.03_am
How to set up and validate locally
- Apply the patch below
Patch for testing
diff --git a/ee/lib/analytics/group_activity_calculator.rb b/ee/lib/analytics/group_activity_calculator.rb
index a2bb06291790..436c7ad26b60 100644
--- a/ee/lib/analytics/group_activity_calculator.rb
+++ b/ee/lib/analytics/group_activity_calculator.rb
@@ -11,25 +11,28 @@ def initialize(group, current_user)
end
def issues_count
- @issues_count ||= fetch_cached(:issues) do
- IssuesFinder.new(@current_user, issuable_params).execute.count
- end
+ @issues_count ||= 1000
+ # @issues_count ||= fetch_cached(:issues) do
+ # IssuesFinder.new(@current_user, issuable_params).execute.count
+ # end
end
def merge_requests_count
- @merge_requests_count ||= fetch_cached(:merge_requests) do
- MergeRequestsFinder.new(@current_user, issuable_params).execute.count
- end
+ @merge_requests_count ||= 999
+ # @merge_requests_count ||= fetch_cached(:merge_requests) do
+ # MergeRequestsFinder.new(@current_user, issuable_params).execute.count
+ # end
end
def new_members_count
- @new_members_count ||= fetch_cached(:new_members) do
- GroupMembersFinder.new(
- @group,
- @current_user,
- params: { created_after: RECENT_DURATION.ago }
- ).execute(include_relations: [:direct, :descendants]).count
- end
+ @new_members_count ||= 998
+ # @new_members_count ||= fetch_cached(:new_members) do
+ # GroupMembersFinder.new(
+ # @group,
+ # @current_user,
+ # params: { created_after: RECENT_DURATION.ago }
+ # ).execute(include_relations: [:direct, :descendants]).count
+ # end
end
private
- Navigate to any group page
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #366919 (closed)
Edited by Ezekiel Kigbo