Fix non menu-item button styles in dropdowns
What does this MR do and why?
At first there was a dark mode bug. The hover style of the Apply suggestion button had black text.
There are some inherited styles for dropdown buttons, which we don't want for other buttons.
Have instead only style direct children of lis. There could still be some false positives,
but this should avoid a lot of unwanted button styles
Screenshots or screen recordings
| before | after | light mode (same) |
|---|---|---|
 |
 |
 |
How to set up and validate locally
- Apply a suggestion to a diff
- Hover the button
- Check for regressions with every other dropdown with links or buttons in it
😅
Risks
The main risk is losing styles on buttons that aren't direct descendants of an li inside a dropdown.
The > doesn't increase specificity, so we aren't adding any new styles, but only reducing the number of elements we apply this rule to.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Simon Knox